[ https://issues.apache.org/jira/browse/HIVE-19097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560284#comment-16560284 ]
Hive QA commented on HIVE-19097: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12933398/HIVE-19097.04.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 78 failed/errored test(s), 14814 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[alter_partition_coltype] (batchId=27) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_filter] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_part] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join19] (batchId=68) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_rp_simple_select] (batchId=49) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_simple_select] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[druid_basic3] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[druid_intervals] (batchId=24) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[dynamic_partition_skip_default] (batchId=85) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[filter_cond_pushdown] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[fold_eq_with_case_when] (batchId=86) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[list_bucket_query_multiskew_2] (batchId=73) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pcr] (batchId=63) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pointlookup2] (batchId=86) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pointlookup3] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[pointlookup] (batchId=4) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_transform] (batchId=81) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[remove_exprs_stats] (batchId=93) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stat_estimate_related_col] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_non_constant_in_expr] (batchId=80) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorized_case] (batchId=61) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketpruning1] (batchId=179) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_7] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[cbo_simple_select] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynamic_partition_pruning] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[enforce_constraint_notnull] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[kryo] (batchId=166) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_decimal64_reader] (batchId=168) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_rewrite_ssb] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[materialized_view_rewrite_ssb_2] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_between_in] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_string_decimal] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_multipartitioning] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_windowing_navfn] (batchId=158) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_case] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_dynamic_partition_pruning] (batchId=163) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning] (batchId=186) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=187) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=106) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join19] (batchId=137) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[bucketsortoptimize_insert_7] (batchId=132) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[cbo_simple_select] (batchId=116) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[pcr] (batchId=135) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_transform] (batchId=143) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vector_between_in] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_case] (batchId=134) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query13] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query15] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query34] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query45] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query48] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query53] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query63] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query71] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query73] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query85] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query89] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query8] (batchId=265) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query91] (batchId=265) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query13] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query15] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query34] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query45] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query48] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query53] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query63] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query71] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query73] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query85] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query89] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query8] (batchId=263) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query91] (batchId=263) org.apache.hadoop.hive.ql.TestTxnCommands2.testMmTableCompaction (batchId=296) org.apache.hadoop.hive.ql.TestTxnCommands2.testOpenTxnsCounter (batchId=296) org.apache.hadoop.hive.ql.TestTxnCommands2.testUpdateMixedCase (batchId=296) org.apache.hadoop.hive.ql.plan.mapping.TestCounterMapping.testInConversion (batchId=310) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12904/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12904/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12904/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 78 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12933398 - PreCommit-HIVE-Build > related equals and in operators may cause inaccurate stats estimations > ---------------------------------------------------------------------- > > Key: HIVE-19097 > URL: https://issues.apache.org/jira/browse/HIVE-19097 > Project: Hive > Issue Type: Bug > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Priority: Major > Attachments: HIVE-19097.01.patch, HIVE-19097.02.patch, > HIVE-19097.03.patch, HIVE-19097.04.patch, HIVE-19097.partial.patch > > > tpcds#74 is optimized in a way that for date_dim the condition contains IN > and = for the same column > {code:java} > | Map Operator Tree: | > | TableScan | > | alias: date_dim | > | filterExpr: (((d_year) IN (2001, 2002) and (d_year = > 2002) and d_date_sk is not null) or ((d_year) IN (2001, 2002) and (d_year = > 2001) and d_date_sk is not null)) (type: boolean) | > | Statistics: Num rows: 73049 Data size: 876588 Basic > stats: COMPLETE Column stats: COMPLETE | > | Filter Operator | > | predicate: ((d_year) IN (2001, 2002) and (d_year = > 2002) and d_date_sk is not null) (type: boolean) | > | Statistics: Num rows: 4 Data size: 48 Basic stats: > COMPLETE Column stats: COMPLETE | > {code} > the "real" row count will be 365 > for separate {{IN}} and {{=}} the estimation is very good; but if both are > present it becomes (very) underestimated. > {code:java} > set hive.query.results.cache.enabled=false; > drop table if exists t1; > drop table if exists t8; > create table t1 (a integer,b integer); > create table t8 like t1; > insert into t1 values (1,1),(2,2),(3,3),(4,4),(5,5); > insert into t8 > select * from t1 union all select * from t1 union all select * from t1 union > all select * from t1 union all > select * from t1 union all select * from t1 union all select * from t1 union > all select * from t1 > ; > analyze table t1 compute statistics for columns; > analyze table t8 compute statistics for columns; > explain analyze select sum(a) from t8 where b in (2,3) group by b; > explain analyze select sum(a) from t8 where b=2 group by b; > explain analyze select sum(a) from t1 where b in (2,3) and b=2 group by b; > explain analyze select sum(a) from t8 where b in (2,3) and b=2 group by b; > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)