[ 
https://issues.apache.org/jira/browse/HIVE-11190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618069#comment-14618069
 ] 

Dapeng Sun commented on HIVE-11190:
-----------------------------------

Hi [~thejas] 
{quote}
What is the use case you have in mind ? Are you using sql standard 
authorization in this case or another custom V2 authorization implementation ? 
Would it work to move the logic from your custom filter hook to 
HiveAuthorizer.filterListCmdObjects implementation ?
{quote}
Yes, I'm using {{another custom V2 authorization implementation}}, I think it's 
good suggestion to move the logic to HiveAuthorizer.filterListCmdObjects 
implementation. 
Hi [~Ferd]
{quote}
 I think it's not a good practice to override METASTORE_FILTER_HOOK by hard 
code. In a conservative way, we may provide the user a warning in the log or 
description to warn this property is overrided in the run time. 
{quote}
This is a good suggestion, I'm agreed with you. 



> ConfVars.METASTORE_FILTER_HOOK in authorization V2 should not be hard code 
> when the value is not default
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-11190
>                 URL: https://issues.apache.org/jira/browse/HIVE-11190
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Dapeng Sun
>            Assignee: Dapeng Sun
>         Attachments: HIVE-11190.001.patch
>
>
> ConfVars.METASTORE_FILTER_HOOK in authorization V2 should not be hard code 
> when the value is not default.
> it will cause user failed to customize the METASTORE_FILTER_HOOK



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to