[
https://issues.apache.org/jira/browse/HIVE-20245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16558109#comment-16558109
]
Hive QA commented on HIVE-20245:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
44s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
51s{color} | {color:blue} ql in master has 2296 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
50s{color} | {color:red} ql in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
12s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} ql: The patch generated 103 new + 854 unchanged - 27
fixed = 957 total (was 881) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} vector-code-gen: The patch generated 8 new + 322
unchanged - 0 fixed = 330 total (was 322) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
9s{color} | {color:red} ql generated 14 new + 2293 unchanged - 3 fixed = 2307
total (was 2296) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Redundant nullcheck of filterExpr, which is known to be non-null in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.createDecimal64VectorExpression(Class,
List, VectorExpressionDescriptor$Mode, boolean, int, TypeInfo,
DataTypePhysicalVariation) Redundant null check at
VectorizationContext.java:is known to be non-null in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.createDecimal64VectorExpression(Class,
List, VectorExpressionDescriptor$Mode, boolean, int, TypeInfo,
DataTypePhysicalVariation) Redundant null check at
VectorizationContext.java:[line 1669] |
| | Redundant nullcheck of vectorExpression, which is known to be non-null in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.createDecimal64VectorExpression(Class,
List, VectorExpressionDescriptor$Mode, boolean, int, TypeInfo,
DataTypePhysicalVariation) Redundant null check at
VectorizationContext.java:is known to be non-null in
org.apache.hadoop.hive.ql.exec.vector.VectorizationContext.createDecimal64VectorExpression(Class,
List, VectorExpressionDescriptor$Mode, boolean, int, TypeInfo,
DataTypePhysicalVariation) Redundant null check at
VectorizationContext.java:[line 1716] |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColumnBetween
defines non-transient non-serializable instance field leftValue In
DecimalColumnBetween.java:instance field leftValue In
DecimalColumnBetween.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColumnBetween
defines non-transient non-serializable instance field rightValue In
DecimalColumnBetween.java:instance field rightValue In
DecimalColumnBetween.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColumnNotBetween
defines non-transient non-serializable instance field leftValue In
DecimalColumnNotBetween.java:instance field leftValue In
DecimalColumnNotBetween.java |
| | Class
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.DecimalColumnNotBetween
defines non-transient non-serializable instance field rightValue In
DecimalColumnNotBetween.java:instance field rightValue In
DecimalColumnNotBetween.java |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.StringColumnBetween(int,
byte[], byte[], int) may expose internal representation by storing an
externally mutable object into StringColumnBetween.left At
StringColumnBetween.java:may expose internal representation by storing an
externally mutable object into StringColumnBetween.left At
StringColumnBetween.java:[line 51] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.StringColumnBetween(int,
byte[], byte[], int) may expose internal representation by storing an
externally mutable object into StringColumnBetween.right At
StringColumnBetween.java:may expose internal representation by storing an
externally mutable object into StringColumnBetween.right At
StringColumnBetween.java:[line 52] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.StringColumnNotBetween(int,
byte[], byte[], int) may expose internal representation by storing an
externally mutable object into StringColumnNotBetween.left At
StringColumnNotBetween.java:may expose internal representation by storing an
externally mutable object into StringColumnNotBetween.left At
StringColumnNotBetween.java:[line 51] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.StringColumnNotBetween(int,
byte[], byte[], int) may expose internal representation by storing an
externally mutable object into StringColumnNotBetween.right At
StringColumnNotBetween.java:may expose internal representation by storing an
externally mutable object into StringColumnNotBetween.right At
StringColumnNotBetween.java:[line 52] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.TimestampColumnBetween(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into TimestampColumnBetween.leftValue At
TimestampColumnBetween.java:may expose internal representation by storing an
externally mutable object into TimestampColumnBetween.leftValue At
TimestampColumnBetween.java:[line 58] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.TimestampColumnBetween(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into TimestampColumnBetween.rightValue At
TimestampColumnBetween.java:may expose internal representation by storing an
externally mutable object into TimestampColumnBetween.rightValue At
TimestampColumnBetween.java:[line 59] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.TimestampColumnNotBetween(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into TimestampColumnNotBetween.leftValue At
TimestampColumnNotBetween.java:may expose internal representation by storing an
externally mutable object into TimestampColumnNotBetween.leftValue At
TimestampColumnNotBetween.java:[line 58] |
| | new
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.TimestampColumnNotBetween(int,
Timestamp, Timestamp, int) may expose internal representation by storing an
externally mutable object into TimestampColumnNotBetween.rightValue At
TimestampColumnNotBetween.java:may expose internal representation by storing an
externally mutable object into TimestampColumnNotBetween.rightValue At
TimestampColumnNotBetween.java:[line 59] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12874/dev-support/hive-personality.sh
|
| git revision | master / 2820fc4 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12874/yetus/patch-mvninstall-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12874/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12874/yetus/diff-checkstyle-vector-code-gen.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12874/yetus/new-findbugs-ql.html
|
| modules | C: ql vector-code-gen U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12874/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Vectorization: Fix NULL / Wrong Results issues in BETWEEN / IN
> --------------------------------------------------------------
>
> Key: HIVE-20245
> URL: https://issues.apache.org/jira/browse/HIVE-20245
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Attachments: HIVE-20245.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches
> to checks for NULL and Wrong Results for vectorized BETWEEN and IN.
> Add, missing vectorization classes for BETWEEN PROJECTION.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
