[ https://issues.apache.org/jira/browse/HIVE-20049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16532270#comment-16532270 ]
Hive QA commented on HIVE-20049: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12930083/HIVE-20049.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 79 failed/errored test(s), 14636 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_select] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_SortUnionTransposeRule] (batchId=16) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[cbo_input26] (batchId=2) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[char_union1] (batchId=17) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[constant_prop_1] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas_colname] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[groupby1_limit] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input11_limit] (batchId=31) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input14_limit] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input1_limit] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input25] (batchId=47) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input26] (batchId=87) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input4_limit] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[input_part10] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_into3] (batchId=28) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_into4] (batchId=18) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_into5] (batchId=33) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_into6] (batchId=75) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lateral_view_noalias] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[lateral_view_onview] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[limit_pushdown_negative] (batchId=42) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[load_dyn_part14] (batchId=93) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[merge4] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[nonreserved_keywords_insert_into1] (batchId=27) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_avro_partition_uniontype] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[parquet_mixed_partition_formats2] (batchId=62) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[script_pipe] (batchId=78) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[select_column_pruning] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udtf_explode] (batchId=53) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union3] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[union_remove_25] (batchId=93) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[varchar_union1] (batchId=12) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_char_simple] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_varchar_simple] (batchId=80) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timestamptz] (batchId=191) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_joins] (batchId=191) org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_masking] (batchId=191) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_nullscan] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketizedhiveinputformat] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[check_constraint] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[constprog_dpp] (batchId=158) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ctas] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_opt_vectorization] (batchId=168) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[dynpart_sort_optimization] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[enforce_constraint_notnull] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[explainuser_1] (batchId=164) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[lateral_view] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[limit_join_transpose] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[limit_pushdown] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer] (batchId=172) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[orc_predicate_pushdown] (batchId=156) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[parquet_predicate_pushdown] (batchId=161) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[tez_dynpart_hashjoin_3] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union3] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_top_level] (batchId=171) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_annotate_stats_select] (batchId=163) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple] (batchId=167) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_partitioned_date_time] (batchId=175) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple] (batchId=174) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_constprog_dpp] (batchId=186) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=185) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_multi_insert_parallel_orderby] (batchId=186) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ctas] (batchId=110) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input1_limit] (batchId=112) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into3] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[limit_pushdown] (batchId=138) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[load_dyn_part14] (batchId=148) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[optimize_nullscan] (batchId=144) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var2] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_pipe] (batchId=141) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[spark_combine_equivalent_work_2] (batchId=132) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_scalar] (batchId=125) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union3] (batchId=135) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_remove_25] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_top_level] (batchId=135) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12365/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12365/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12365/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 79 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12930083 - PreCommit-HIVE-Build > hive.groupby.limit.extrastep should be false by default > ------------------------------------------------------- > > Key: HIVE-20049 > URL: https://issues.apache.org/jira/browse/HIVE-20049 > Project: Hive > Issue Type: Task > Components: Query Planning > Reporter: Ashutosh Chauhan > Assignee: Laszlo Bodor > Priority: Major > Attachments: HIVE-20049.01.patch, HIVE-20049.02.patch, > HIVE-20049.03.patch > > > In fact this flag is not needed since FetchTask can enforce limit there is > never a reason to have another vertex purely for limit. > > It was introduced by HIVE-12963 -- This message was sent by Atlassian JIRA (v7.6.3#76005)