[ https://issues.apache.org/jira/browse/HIVE-19337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531892#comment-16531892 ]
Hive QA commented on HIVE-19337: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12930033/HIVE-19337.03.branch-2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/12356/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12356/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12356/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-07-03 20:29:28.865 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-12356/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-07-03 20:29:28.869 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive 2ca70b9..cc8ac97 master -> origin/master a47a80f..eb261cb master-txnstats -> origin/master-txnstats + git reset --hard HEAD HEAD is now at 2ca70b9 HIVE-19326 : stats auto gather: incorrect aggregation during UNION queries (may lead to incorrect results) (Zoltan Haindrich via Ashutosh Chauhan) + git clean -f -d + git checkout master Already on 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at cc8ac97 HIVE-19860 : HiveServer2 ObjectInspectorFactory memory leak with cachedUnionStructObjectInspector (Rajkumar Singh) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-07-03 20:29:30.351 + rm -rf ../yetus_PreCommit-HIVE-Build-12356 + mkdir ../yetus_PreCommit-HIVE-Build-12356 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-12356 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-12356/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index error: metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index error: src/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-12356 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12930033 - PreCommit-HIVE-Build > Partition whitelist regex doesn't work (and never did) > ------------------------------------------------------ > > Key: HIVE-19337 > URL: https://issues.apache.org/jira/browse/HIVE-19337 > Project: Hive > Issue Type: Bug > Components: Metastore > Affects Versions: 2.3.3 > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Priority: Major > Attachments: HIVE-19337.01.branch-2.patch, > HIVE-19337.03.branch-2.patch > > > {{ObjectStore.setConf()}} has the following code: > {code:java} > String partitionValidationRegex = > > hiveConf.get(HiveConf.ConfVars.METASTORE_PARTITION_NAME_WHITELIST_PATTERN.name()); > {code} > Note that it uses name() method which returns enum name > (METASTORE_PARTITION_NAME_WHITELIST_PATTERN) rather then .varname > As a result the regex will always be null. > The code was introduced as part of > HIVE-7223 Support generic PartitionSpecs in Metastore partition-functions > So looks like this was broken since the original code drop. This is fixed in > Hive3 - probably when [~alangates] reworked access to configuration > (HIVE-17733) so it isn't a bug in Hive-3. > [~stakiar_impala_496e] FYI. -- This message was sent by Atlassian JIRA (v7.6.3#76005)