[ https://issues.apache.org/jira/browse/HIVE-19532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529509#comment-16529509 ]
Hive QA commented on HIVE-19532: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 31s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 20s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 0s{color} | {color:blue} standalone-metastore in master has 228 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 41s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 35s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 1s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 35s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} storage-api: The patch generated 2 new + 3 unchanged - 0 fixed = 5 total (was 3) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 36s{color} | {color:red} standalone-metastore: The patch generated 70 new + 1726 unchanged - 17 fixed = 1796 total (was 1743) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 47s{color} | {color:red} ql: The patch generated 18 new + 1011 unchanged - 3 fixed = 1029 total (was 1014) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 24s{color} | {color:red} root: The patch generated 92 new + 3295 unchanged - 20 fixed = 3387 total (was 3315) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} itests/hcatalog-unit: The patch generated 2 new + 28 unchanged - 0 fixed = 30 total (was 28) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch has 118 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 2s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 5s{color} | {color:red} standalone-metastore generated 6 new + 227 unchanged - 1 fixed = 233 total (was 228) {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 52s{color} | {color:red} ql generated 1 new + 2287 unchanged - 0 fixed = 2288 total (was 2287) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 59s{color} | {color:red} standalone-metastore generated 3 new + 54 unchanged - 0 fixed = 57 total (was 54) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 5m 34s{color} | {color:red} root generated 3 new + 371 unchanged - 0 fixed = 374 total (was 371) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 78m 35s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:standalone-metastore | | | Dead store to table in org.apache.hadoop.hive.metastore.ObjectStore.dropTable(String, String, String) At ObjectStore.java:org.apache.hadoop.hive.metastore.ObjectStore.dropTable(String, String, String) At ObjectStore.java:[line 1315] | | | Null pointer dereference of partNames in org.apache.hadoop.hive.metastore.ObjectStore.getPartitionColumnStatistics(String, String, String, List, List, long, String) Dereferenced at ObjectStore.java:in org.apache.hadoop.hive.metastore.ObjectStore.getPartitionColumnStatistics(String, String, String, List, List, long, String) Dereferenced at ObjectStore.java:[line 8655] | | | Null pointer dereference of partNames in org.apache.hadoop.hive.metastore.ObjectStore.get_aggr_stats_for(String, String, String, List, List, long, String) Dereferenced at ObjectStore.java:in org.apache.hadoop.hive.metastore.ObjectStore.get_aggr_stats_for(String, String, String, List, List, long, String) Dereferenced at ObjectStore.java:[line 8730] | | | Load of known null value in org.apache.hadoop.hive.metastore.ObjectStore.getPartitionColumnStatistics(String, String, String, List, List, long, String) At ObjectStore.java:in org.apache.hadoop.hive.metastore.ObjectStore.getPartitionColumnStatistics(String, String, String, List, List, long, String) At ObjectStore.java:[line 8655] | | | Load of known null value in org.apache.hadoop.hive.metastore.ObjectStore.get_aggr_stats_for(String, String, String, List, List, long, String) At ObjectStore.java:in org.apache.hadoop.hive.metastore.ObjectStore.get_aggr_stats_for(String, String, String, List, List, long, String) At ObjectStore.java:[line 8730] | | | Redundant nullcheck of tbl, which is known to be non-null in org.apache.hadoop.hive.metastore.cache.CachedStore.getTable(String, String, String, long, String) Redundant null check at CachedStore.java:is known to be non-null in org.apache.hadoop.hive.metastore.cache.CachedStore.getTable(String, String, String, long, String) Redundant null check at CachedStore.java:[line 848] | | FindBugs | module:ql | | | Nullcheck of tableSnapshot at line 4477 of value previously dereferenced in org.apache.hadoop.hive.ql.metadata.Hive.getTableColumnStatistics(String, String, List, boolean) At Hive.java:4477 of value previously dereferenced in org.apache.hadoop.hive.ql.metadata.Hive.getTableColumnStatistics(String, String, List, boolean) At Hive.java:[line 4477] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile xml | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12315/dev-support/hive-personality.sh | | git revision | master / b122aea | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-checkstyle-storage-api.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-checkstyle-standalone-metastore.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-checkstyle-ql.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-checkstyle-root.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-checkstyle-itests_hcatalog-unit.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/whitespace-eol.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/new-findbugs-standalone-metastore.html | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/new-findbugs-ql.html | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-javadoc-javadoc-standalone-metastore.txt | | javadoc | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus/diff-javadoc-javadoc-root.txt | | modules | C: storage-api standalone-metastore ql . itests/hcatalog-unit itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12315/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > fix tests for master-txnstats branch > ------------------------------------ > > Key: HIVE-19532 > URL: https://issues.apache.org/jira/browse/HIVE-19532 > Project: Hive > Issue Type: Sub-task > Components: Transactions > Affects Versions: 3.0.0 > Reporter: Steve Yeom > Assignee: Sergey Shelukhin > Priority: Major > Fix For: 3.2.0 > > Attachments: HIVE-19532.01.patch, HIVE-19532.01.prepatch, > HIVE-19532.02.patch, HIVE-19532.02.prepatch, HIVE-19532.03.patch, > HIVE-19532.04.patch, HIVE-19532.05.patch, HIVE-19532.06.patch, > HIVE-19532.07.patch, HIVE-19532.08.patch, HIVE-19532.09.patch, > HIVE-19532.10.patch, HIVE-19532.11.patch, HIVE-19532.12.patch, > HIVE-19532.13.patch, HIVE-19532.14.patch, HIVE-19532.15.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)