[ https://issues.apache.org/jira/browse/HIVE-18983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527173#comment-16527173 ]
Hive QA commented on HIVE-18983: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 53s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 11s{color} | {color:blue} standalone-metastore in master has 228 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 2s{color} | {color:blue} ql in master has 2287 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 52s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 457 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 6s{color} | {color:red} The patch 499 line(s) with tabs. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 17s{color} | {color:red} ql generated 1 new + 2287 unchanged - 0 fixed = 2288 total (was 2287) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 13s{color} | {color:red} The patch generated 3 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 36m 5s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Possible null pointer dereference of likeTable in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeCreateTable(ASTNode, QB, SemanticAnalyzer$PlannerContext) Dereferenced at SemanticAnalyzer.java:likeTable in org.apache.hadoop.hive.ql.parse.SemanticAnalyzer.analyzeCreateTable(ASTNode, QB, SemanticAnalyzer$PlannerContext) Dereferenced at SemanticAnalyzer.java:[line 13209] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12235/dev-support/hive-personality.sh | | git revision | master / 5b2cbb5 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12235/yetus/whitespace-eol.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-12235/yetus/whitespace-tabs.txt | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12235/yetus/new-findbugs-ql.html | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-12235/yetus/patch-asflicense-problems.txt | | modules | C: standalone-metastore ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12235/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Add support for table properties inheritance in Create table like > ----------------------------------------------------------------- > > Key: HIVE-18983 > URL: https://issues.apache.org/jira/browse/HIVE-18983 > Project: Hive > Issue Type: Improvement > Reporter: Igor Kryvenko > Assignee: Igor Kryvenko > Priority: Major > Fix For: 3.2.0 > > Attachments: HIVE-18983.01.patch, HIVE-18983.02.patch, > HIVE-18983.03.patch, HIVE-18983.04.patch, HIVE-18983.05.patch, > HIVE-18983.06.patch, HIVE-18983.07.patch, HIVE-18983.08.patch, > HIVE-18983.09.patch, HIVE-18983.10.patch, HIVE-18983.11.patch, > HIVE-18983.12.patch > > > Currently, Create table like support table properties. > But it doesn't inherit table properties from original table. > {code} > create table T1(a int, b int) clustered by (a) into 2 buckets stored as orc > TBLPROPERTIES ('comment'='comm'); > create table T like T1; > show create table T; > {code} > *Output:* > {code} > CREATE TABLE `T`( > `a` int, > `b` int) > CLUSTERED BY ( > a) > INTO 2 BUCKETS > ROW FORMAT SERDE > 'org.apache.hadoop.hive.ql.io.orc.OrcSerde' > STORED AS INPUTFORMAT > 'org.apache.hadoop.hive.ql.io.orc.OrcInputFormat' > OUTPUTFORMAT > 'org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat' > LOCATION > 'maprfs:/user/hive/warehouse/t' > TBLPROPERTIES ( > 'COLUMN_STATS_ACCURATE'='{\"BASIC_STATS\":\"true\"}', > 'numFiles'='0', > 'numRows'='0', > 'rawDataSize'='0', > 'totalSize'='0', > 'transient_lastDdlTime'='1521230300') > {code} > It uses just default table properties and doesn't inherit properties from > original table. > It would be great if create table like will inherit origin table properties > and will override them if they are specified in query . -- This message was sent by Atlassian JIRA (v7.6.3#76005)