[ https://issues.apache.org/jira/browse/HIVE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520917#comment-16520917 ]
Hive QA commented on HIVE-4367: ------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 37s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 57s{color} | {color:blue} ql in master has 2282 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 15s{color} | {color:red} ql generated 3 new + 2278 unchanged - 4 fixed = 2281 total (was 2282) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 45s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Should org.apache.hadoop.hive.ql.parse.HiveParser$DFA227 be a _static_ inner class? At HiveParser.java:inner class? At HiveParser.java:[lines 46224-46237] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser$DFA271 be a _static_ inner class? At HiveParser.java:inner class? At HiveParser.java:[lines 46561-46574] | | | Should org.apache.hadoop.hive.ql.parse.HiveParser$DFA286 be a _static_ inner class? At HiveParser.java:inner class? At HiveParser.java:[lines 46697-46710] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-12004/dev-support/hive-personality.sh | | git revision | master / 23d2b80 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-12004/yetus/new-findbugs-ql.html | | modules | C: itests ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-12004/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > enhance TRUNCATE syntex to drop data of external table > -------------------------------------------------------- > > Key: HIVE-4367 > URL: https://issues.apache.org/jira/browse/HIVE-4367 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 0.11.0 > Reporter: caofangkun > Assignee: caofangkun > Priority: Minor > Attachments: HIVE-4367-1.patch, HIVE-4367.2.patch.txt, > HIVE-4367.3.patch, HIVE-4367.4.patch > > > In my use case , > sometimes I have to remove data of external tables to free up storage space > of the cluster . > So it's necessary for to enhance the syntax like > "TRUNCATE TABLE srcpart_truncate PARTITION (dt='201130412') FORCE;" > to remove data from EXTERNAL table. > And I add a configuration property to enable remove data to Trash > <property> > <name>hive.truncate.skiptrash</name> > <value>false</value> > <description> > if true will remove data to trash, else false drop data immediately > </description> > </property> > For example : > hive (default)> TRUNCATE TABLE external1 partition (ds='11'); > FAILED: Error in semantic analysis: Cannot truncate non-managed table > external1 > hive (default)> TRUNCATE TABLE external1 partition (ds='11') FORCE; > [2013-04-16 17:15:52]: Compile Start > [2013-04-16 17:15:52]: Compile End > [2013-04-16 17:15:52]: OK > [2013-04-16 17:15:52]: Time taken: 0.413 seconds > hive (default)> set hive.truncate.skiptrash; > hive.truncate.skiptrash=false > hive (default)> set hive.truncate.skiptrash=true; > hive (default)> TRUNCATE TABLE external1 partition (ds='12') FORCE; > [2013-04-16 17:16:21]: Compile Start > [2013-04-16 17:16:21]: Compile End > [2013-04-16 17:16:21]: OK > [2013-04-16 17:16:21]: Time taken: 0.143 seconds > hive (default)> dfs -ls /user/test/.Trash/Current/; > Found 1 items > drwxr-xr-x -test supergroup 0 2013-04-16 17:06 /user/test/.Trash/Current/ds=11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)