[
https://issues.apache.org/jira/browse/HIVE-18875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16501247#comment-16501247
]
Gunther Hagleitner commented on HIVE-18875:
-------------------------------------------
Left comments on review board. The main things are:
a) I'm still hoping to remove the new code that checks cols in
convertJoinMapJoin. That seems redundant.
b) I'm hoping that new code in gby isn't needed. I left more thoughts on RB.
I'm hoping that can be taken out right away.
Other than that - the patch looks good.
> Enable SMB Join by default in Tez
> ---------------------------------
>
> Key: HIVE-18875
> URL: https://issues.apache.org/jira/browse/HIVE-18875
> Project: Hive
> Issue Type: Task
> Reporter: Deepak Jaiswal
> Assignee: Deepak Jaiswal
> Priority: Major
> Attachments: HIVE-18875.1.patch, HIVE-18875.10.patch,
> HIVE-18875.11.patch, HIVE-18875.12.patch, HIVE-18875.13.patch,
> HIVE-18875.2.patch, HIVE-18875.3.patch, HIVE-18875.4.patch,
> HIVE-18875.5.patch, HIVE-18875.6.patch, HIVE-18875.7.patch,
> HIVE-18875.8.patch, HIVE-18875.9.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
