[ https://issues.apache.org/jira/browse/HIVE-19382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499785#comment-16499785 ]
Hive QA commented on HIVE-19382: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12926018/HIVE-19382.05.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14451 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11489/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11489/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11489/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12926018 - PreCommit-HIVE-Build > Acquire locks before generating valid transaction list for some operations > -------------------------------------------------------------------------- > > Key: HIVE-19382 > URL: https://issues.apache.org/jira/browse/HIVE-19382 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 3.0.0 > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Priority: Major > Attachments: HIVE-19382.01.patch, HIVE-19382.02.patch, > HIVE-19382.03.patch, HIVE-19382.04.patch, HIVE-19382.05.patch, > HIVE-19382.patch > > > To ensure correctness, in particular for operations that require exclusive > ({{INSERT OVERWRITE}}) and semishared ({{UPDATE}}/{{DELETE}}) locks. > This is a temporary fix till lock acquisition is moved before analyze in > HIVE-18948. > With this fix, system proceed as follows. The driver will acquire the > snapshot, compile the query wrt that snapshot, and then, it will acquire > locks. If snapshot is still valid, it will continue as usual. But if snapshot > is not valid anymore, it will recompile the query. > This is easier to implement than full solution described in HIVE-18948 > because we do not need to move the logic to extract the read/write entities > from a query before compilation (actually while parsing). -- This message was sent by Atlassian JIRA (v7.6.3#76005)