[ https://issues.apache.org/jira/browse/HIVE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499349#comment-16499349 ]
Hive QA commented on HIVE-12192: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12926116/HIVE-12192.08.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11468/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11468/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11468/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12926116/HIVE-12192.08.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12926116 - PreCommit-HIVE-Build > Hive should carry out timestamp computations in UTC > --------------------------------------------------- > > Key: HIVE-12192 > URL: https://issues.apache.org/jira/browse/HIVE-12192 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: Ryan Blue > Assignee: Jesus Camacho Rodriguez > Priority: Blocker > Labels: timestamp > Attachments: HIVE-12192.01.patch, HIVE-12192.02.patch, > HIVE-12192.03.patch, HIVE-12192.04.patch, HIVE-12192.05.patch, > HIVE-12192.06.patch, HIVE-12192.07.patch, HIVE-12192.08.patch, > HIVE-12192.patch > > > Hive currently uses the "local" time of a java.sql.Timestamp to represent the > SQL data type TIMESTAMP WITHOUT TIME ZONE. The purpose is to be able to use > {{Timestamp#getYear()}} and similar methods to implement SQL functions like > {{year}}. > When the SQL session's time zone is a DST zone, such as America/Los_Angeles > that alternates between PST and PDT, there are times that cannot be > represented because the effective zone skips them. > {code} > hive> select TIMESTAMP '2015-03-08 02:10:00.101'; > 2015-03-08 03:10:00.101 > {code} > Using UTC instead of the SQL session time zone as the underlying zone for a > java.sql.Timestamp avoids this bug, while still returning correct values for > {{getYear}} etc. Using UTC as the convenience representation (timestamp > without time zone has no real zone) would make timestamp calculations more > consistent and avoid similar problems in the future. > Notably, this would break the {{unix_timestamp}} UDF that specifies the > result is with respect to ["the default timezone and default > locale"|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-DateFunctions]. > That function would need to be updated to use the > {{System.getProperty("user.timezone")}} zone. -- This message was sent by Atlassian JIRA (v7.6.3#76005)