[
https://issues.apache.org/jira/browse/HIVE-19460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492137#comment-16492137
]
Hive QA commented on HIVE-19460:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
31s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
28s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
29s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
39s{color} | {color:blue} ql in master has 2324 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
9s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
6s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
42s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
40s{color} | {color:red} root: The patch generated 14 new + 639 unchanged - 2
fixed = 653 total (was 641) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
36s{color} | {color:red} ql: The patch generated 14 new + 212 unchanged - 2
fixed = 226 total (was 214) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
37s{color} | {color:red} ql generated 7 new + 2324 unchanged - 0 fixed = 2331
total (was 2324) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 52m 18s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At
StatsRulesProcFactory.java:org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At StatsRulesProcFactory.java:[line 601] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At
StatsRulesProcFactory.java:org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At StatsRulesProcFactory.java:[line 607] |
| |
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
invokes inefficient new Byte(String) constructor; use Byte.valueOf(String)
instead At StatsRulesProcFactory.java:constructor; use Byte.valueOf(String)
instead At StatsRulesProcFactory.java:[line 582] |
| |
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
invokes inefficient new Integer(String) constructor; use
Integer.valueOf(String) instead At StatsRulesProcFactory.java:constructor; use
Integer.valueOf(String) instead At StatsRulesProcFactory.java:[line 601] |
| |
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead At StatsRulesProcFactory.java:constructor; use Long.valueOf(String)
instead At StatsRulesProcFactory.java:[line 607] |
| |
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
invokes inefficient new Short(String) constructor; use Short.valueOf(String)
instead At StatsRulesProcFactory.java:constructor; use Short.valueOf(String)
instead At StatsRulesProcFactory.java:[line 588] |
| | Exception is caught when Exception is not thrown in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At StatsRulesProcFactory.java:is not thrown in
org.apache.hadoop.hive.ql.optimizer.stats.annotation.StatsRulesProcFactory$FilterStatsRule$RangeOps.intersect(ExprNodeDesc)
At StatsRulesProcFactory.java:[line 627] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile
xml |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11267/dev-support/hive-personality.sh
|
| git revision | master / 2f797d2 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11267/yetus/diff-checkstyle-root.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11267/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11267/yetus/new-findbugs-ql.html
|
| modules | C: common . ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11267/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Improve stats estimations for NOT IN operator
> ---------------------------------------------
>
> Key: HIVE-19460
> URL: https://issues.apache.org/jira/browse/HIVE-19460
> Project: Hive
> Issue Type: Bug
> Components: Statistics
> Reporter: Zoltan Haindrich
> Assignee: Zoltan Haindrich
> Priority: Major
> Attachments: HIVE-19460.01wip01.patch, HIVE-19460.01wip02.patch,
> HIVE-19460.01wip03.patch, HIVE-19460.02.patch, HIVE-19460.03.patch,
> HIVE-19460.04.patch, HIVE-19460.05.patch, HIVE-19460.06.patch,
> HIVE-19460.07.patch, HIVE-19460.07.patch, HIVE-19460.08.patch,
> HIVE-19460.09.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)