[ 
https://issues.apache.org/jira/browse/HIVE-18533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466648#comment-16466648
 ] 

Sahil Takiar commented on HIVE-18533:
-------------------------------------

[~lirui] yeah that might be slightly simpler. Although the specific example you 
mentioned shouldn't be an issue. Calling {{SparkAppHandle#stop}} should cause 
the Spark App to transition to a stopped state, in which case the 
{{SparkAppHandle.Listener}} will decrement the count down latch.

I don't think it would be as simple as wrapping the countdown latch in a 
{{FutureTask}}, there still needs to be a way to cancel the underlying Spark 
app if {{#interrupt}} is called.

Plus there are unit tests for {{SparkLauncherFuture}}, although I can add in 
some more to ensure the {{Future}} contract isn't broken.

> Add option to use InProcessLauncher to submit spark jobs
> --------------------------------------------------------
>
>                 Key: HIVE-18533
>                 URL: https://issues.apache.org/jira/browse/HIVE-18533
>             Project: Hive
>          Issue Type: Improvement
>          Components: Spark
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18533.1.patch, HIVE-18533.2.patch, 
> HIVE-18533.3.patch, HIVE-18533.4.patch, HIVE-18533.5.patch, 
> HIVE-18533.6.patch, HIVE-18533.7.patch, HIVE-18533.8.patch, 
> HIVE-18533.9.patch, HIVE-18533.91.patch, HIVE-18831.93.patch
>
>
> See discussion in HIVE-16484 for details.
> I think this will help with reducing the amount of time it takes to open a 
> HoS session + debuggability (no need launch a separate process to run a Spark 
> app).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to