[ https://issues.apache.org/jira/browse/HIVE-19354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464832#comment-16464832 ]
Hive QA commented on HIVE-19354: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 35s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 42s{color} | {color:red} ql: The patch generated 2 new + 1 unchanged - 1 fixed = 3 total (was 2) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 13s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10712/dev-support/hive-personality.sh | | git revision | master / 0d517bf | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10712/yetus/diff-checkstyle-ql.txt | | modules | C: serde ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10712/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > from_utc_timestamp returns incorrect results for datetime values with timezone > ------------------------------------------------------------------------------ > > Key: HIVE-19354 > URL: https://issues.apache.org/jira/browse/HIVE-19354 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.1.0 > Reporter: Bruce Robbins > Assignee: Bharathkrishna Guruvayoor Murali > Priority: Major > Attachments: HIVE-19354.01.patch > > > On the master branch, from_utc_timestamp returns incorrect results for > datetime strings that containĀ a timezone: > {noformat} > hive> select from_utc_timestamp('2000-10-10 00:00:00+00:00', > 'America/Los_Angeles'); > OK > 2000-10-09 10:00:00 > Time taken: 0.294 seconds, Fetched: 1 row(s) > hive> select from_utc_timestamp('2000-10-10 00:00:00', 'America/Los_Angeles'); > OK > 2000-10-09 17:00:00 > Time taken: 0.121 seconds, Fetched: 1 row(s) > hive> > {noformat} > Both inputs are 2000-10-10 00:00:00 in UTC time, but I got two different > results. > In version 2.3.3, from_utc_timestamp doesn't accept timezones in its input > strings, so it does not have this bug: > {noformat} > hive> select from_utc_timestamp('2000-10-10 00:00:00+00:00', > 'America/Los_Angeles'); > OK > NULL > Time taken: 5.152 seconds, Fetched: 1 row(s) > hive> select from_utc_timestamp('2000-10-10 00:00:00', 'America/Los_Angeles'); > OK > 2000-10-09 17:00:00 > Time taken: 0.069 seconds, Fetched: 1 row(s) > hive> > {noformat} > Since the function is expecting a UTC datetime value, it probably should > continue to reject input that contains a timezone component. -- This message was sent by Atlassian JIRA (v7.6.3#76005)