[ 
https://issues.apache.org/jira/browse/HIVE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464587#comment-16464587
 ] 

Hive QA commented on HIVE-18906:
--------------------------------

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
48s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 19s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10699/dev-support/hive-personality.sh
 |
| git revision | master / 52f1b24 |
| Default Java | 1.8.0_111 |
| modules | C: standalone-metastore U: standalone-metastore |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-10699/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Lower Logging for "Using direct SQL"
> ------------------------------------
>
>                 Key: HIVE-18906
>                 URL: https://issues.apache.org/jira/browse/HIVE-18906
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: Antal Sinkovits
>            Priority: Trivial
>              Labels: noob
>         Attachments: HIVE-18906.1.patch
>
>
> https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java#L181
> {code}
> 2018-02-26 14:32:50,620  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:09,566  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:43,170  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:46,301  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:16,966  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:18,072  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-196]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:25,064  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:51,781  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:35:04,685  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:35:26,689  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> {code}
> I wouldn't mind knowing this information when the service starts up and 
> detects that there is a Direct SQL compatible database, but I don't need to 
> know about this every time.
> Please lower to _debug_ level logging and parameterize with SLF4J.  Direct 
> SQL is a performance thing and not something I care about during the normal 
> course of operation (unless there is an error which would presumably be 
> covered by an _error_ logging message).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to