[ 
https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462877#comment-16462877
 ] 

Vihang Karajgaonkar commented on HIVE-19041:
--------------------------------------------

Thanks [~stakiar] for taking a look.

I missed the type field in FieldSchema. Will work on that. I don't think we 
should intern comment though. Comments generally should not need to be interned 
since they will typically have different values. On a second thought, it might 
make sense to intern them for Partition's FieldSchema in case users have 
comments on the partition columns.

Will take a look at setCatName and parameters. I thought parameters were 
handled separately.

> Thrift deserialization of Partition objects should intern fields
> ----------------------------------------------------------------
>
>                 Key: HIVE-19041
>                 URL: https://issues.apache.org/jira/browse/HIVE-19041
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 3.0.0, 2.3.2
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>         Attachments: HIVE-19041.01.patch
>
>
> When a client is creating large number of partitions, the thrift objects are 
> deserialized into Partition objects. The read method of these objects does 
> not intern the inputformat, location, outputformat which cause large number 
> of duplicate Strings in the HMS memory. We should intern these objects while 
> deserialization to reduce memory pressure. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to