[ 
https://issues.apache.org/jira/browse/HIVE-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593833#comment-14593833
 ] 

Yongzhi Chen commented on HIVE-11042:
-------------------------------------

[~csun], I think replaceTaskId( string , int) is a right name, we may need fix 
other method names. I will submit a different jira and work on it once I am 
fully understand other methods' use case. 
I make it public because I could do some unit test on it. It should have no 
harm. We have a couple of replaceTask...method is public too.
I do not know why my git diff always give me previous version of change, but 
after I create a new branch and cherry-pick my change, the issue is solved. 
Attach new version of patch 2. Thanks. 

> Need fix Utilities.replaceTaskId method
> ---------------------------------------
>
>                 Key: HIVE-11042
>                 URL: https://issues.apache.org/jira/browse/HIVE-11042
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>    Affects Versions: 1.2.0
>            Reporter: Yongzhi Chen
>            Assignee: Yongzhi Chen
>         Attachments: HIVE-11042.1.patch, HIVE-11042.2.patch
>
>
> When I are looking at other bug, I found Utilities.replaceTaskId (String, 
> int) method is not right.
> For example 
> Utilities.replaceTaskId"(ds%3D1)000001", 5); 
> return 0000000000005
> It should return (ds%3D1)000005



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to