[
https://issues.apache.org/jira/browse/HIVE-19322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457211#comment-16457211
]
Eugene Koifman edited comment on HIVE-19322 at 4/27/18 11:31 PM:
-----------------------------------------------------------------
{noformat}
commit 699c5768c88967abd507122d775bd5955ca45218
Author: Eugene Koifman <ekoif...@apache.org>
Date: Tue Apr 17 18:23:13 2018 -0700
HIVE-18739 - Add support for Import/Export from Acid table (Eugene Koifman,
reviewed by Sergey Shelukhin)
commit bd6b582581de461e620ac9220b862e938dfec8cd
Author: Ashutosh Chauhan <hashut...@apache.org>
Date: Tue Apr 17 18:17:35 2018 -0700
HIVE-19235 : Update golden files for Minimr tests
commit 4cfec3eb9c4c47df6195692ef535b42f9ac36588
Author: Vaibhav Gumashta <vgumas...@hortonworks.com>
Date: Tue Apr 17 12:53:40 2018 -0700
HIVE-19126: CachedStore: Use memory estimation to limit cache size during
prewarm (Vaibhav Gumashta reviewed by Thejas Nair)
{noformat}
If I checkout to just before HIVE-18739 then all the following tests pass and
fail if I include HIVE-18739.
{noformat}
mvn test -Dtest=TestNegativeMinimrCliDriver
-Dqfile=cluster_tasklog_retrieval.q,mapreduce_stack_trace.q,mapreduce_stack_trace_turnoff.q,minimr_broken_pipe.q;
mvn test -Dtest=TestNegativeCliDriver
-Dqfile=subquery_corr_in_agg.q,subquery_scalar_corr_multi_rows.q,udf_assert_true.q,script_broken_pipe2.q
{noformat}
The attached patch fixes all the tests, however if I checkout HEAD the tests
TestNegativeMinimrCliDriver are still fixed by the patch but not any of
TestNegativeCliDriver tests even though the diff that is output is exactly the
same. TestNegativeCliDriver clearly could be improved wrt error logging.
So TestNegativeCliDriver will need to be looked at separately in another ticket.
was (Author: ekoifman):
{noformat}
commit 699c5768c88967abd507122d775bd5955ca45218
Author: Eugene Koifman <ekoif...@apache.org>
Date: Tue Apr 17 18:23:13 2018 -0700
HIVE-18739 - Add support for Import/Export from Acid table (Eugene Koifman,
reviewed by Sergey Shelukhin)
commit bd6b582581de461e620ac9220b862e938dfec8cd
Author: Ashutosh Chauhan <hashut...@apache.org>
Date: Tue Apr 17 18:17:35 2018 -0700
HIVE-19235 : Update golden files for Minimr tests
commit 4cfec3eb9c4c47df6195692ef535b42f9ac36588
Author: Vaibhav Gumashta <vgumas...@hortonworks.com>
Date: Tue Apr 17 12:53:40 2018 -0700
HIVE-19126: CachedStore: Use memory estimation to limit cache size during
prewarm (Vaibhav Gumashta reviewed by Thejas Nair)
{noformat}
If I checkout to just before HIVE-18739 then all the following tests pass and
fail if I include HIVE-18739.
mvn test -Dtest=TestNegativeMinimrCliDriver
-Dqfile=cluster_tasklog_retrieval.q,mapreduce_stack_trace.q,mapreduce_stack_trace_turnoff.q,minimr_broken_pipe.q;
mvn test -Dtest=TestNegativeCliDriver
-Dqfile=subquery_corr_in_agg.q,subquery_scalar_corr_multi_rows.q,udf_assert_true.q,script_broken_pipe2.q
The attached patch fixes all the tests, however if I checkout HEAD the tests
TestNegativeMinimrCliDriver are still fixed by the patch but not any of
TestNegativeCliDriver tests even though the diff that is output is exactly the
same. TestNegativeCliDriver clearly could be improved wrt error logging.
So TestNegativeCliDriver will need to be looked at separately in another ticket.
> broken test: TestNegativeMinimrCliDriver#testCliDriver[minimr_broken_pipe]
> --------------------------------------------------------------------------
>
> Key: HIVE-19322
> URL: https://issues.apache.org/jira/browse/HIVE-19322
> Project: Hive
> Issue Type: Sub-task
> Components: Test, Transactions
> Affects Versions: 3.0.0
> Reporter: Eugene Koifman
> Assignee: Eugene Koifman
> Priority: Major
> Attachments: HIVE-19322.02.patch
>
>
> this is apparently caused by HIVE-18739, specifically changing
> {{private static ThreadLocal<SessionStates> tss}} in {{SessionState}} to
> {{private static InheritableThreadLocal<SessionStates> tss}}
> need to figure out why this is.
> Looks like
> {{TestNegativeMinimrCliDriver
> -Dqfile=mapreduce_stack_trace_turnoff.q,mapreduce_stack_trace.q,cluster_tasklog_retrieval.q}}
> are also broken by this
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
