[
https://issues.apache.org/jira/browse/HIVE-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444022#comment-16444022
]
Hive QA commented on HIVE-19158:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
25s{color} | {color:red} standalone-metastore: The patch generated 2 new + 634
unchanged - 18 fixed = 636 total (was 652) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
17s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 27s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10342/dev-support/hive-personality.sh
|
| git revision | master / 5ae174c |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10342/yetus/diff-checkstyle-standalone-metastore.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10342/yetus/patch-asflicense-problems.txt
|
| modules | C: standalone-metastore U: standalone-metastore |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10342/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Fix NPE in the HiveMetastore add partition tests
> ------------------------------------------------
>
> Key: HIVE-19158
> URL: https://issues.apache.org/jira/browse/HIVE-19158
> Project: Hive
> Issue Type: Bug
> Components: Metastore, Test
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Minor
> Attachments: HIVE-19158.1.patch, HIVE-19158.2.patch,
> HIVE-19158.3.patch
>
>
> The TestAddPartitions and TestAddPartitionsFromPartSpec tests revealed that
> NPE is thrown in some cases. These NPEs could be prevented with a simple null
> check and a MetaException with a proper error message should be thrown
> instead.
> Example: NPE is thrown in the following test cases
> * TestAddPartitions
> ** testAddPartitionNullPartition
> ** testAddPartitionNullValue
> ** testAddPartitionsNullList
> * TestAddPartitionsFromPartSpec
> ** testAddPartitionSpecNullSpec
> ** testAddPartitionSpecNullPartList
> ** testAddPartitionSpecNoDB
> ** testAddPartitionSpecNoTable
> ** testAddPartitionSpecNoDBAndTableInPartition
> ** testAddPartitionSpecNullPart
> ** testAddPartitionSpecChangeRootPathToNull
> ** testAddPartitionSpecWithSharedSDNullSd
> ** testAddPartitionSpecWithSharedSDNoValue
> ** testAddPartitionSpecNullValue
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
