[ https://issues.apache.org/jira/browse/HIVE-19194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440138#comment-16440138 ]
slim bouguerra commented on HIVE-19194: --------------------------------------- *Issue* Bug is introduced by HIVE-19157. The bug is actually covered by the test case {code} testCommitMultiInsertOverwriteTable{code} Issuer raises when we have an Insert overwrite statement with 0 rows and the code was existing without disabling the existing Druid DataSource. *Fix* This patch adds a step to disable Druid Datasource if it is an insert overwrite statement. *Improvement* I have done some refactoring to make the code more readable and can be broken into small functions. > TestDruidStorageHandler fails > ----------------------------- > > Key: HIVE-19194 > URL: https://issues.apache.org/jira/browse/HIVE-19194 > Project: Hive > Issue Type: Sub-task > Components: Druid integration > Reporter: Ashutosh Chauhan > Assignee: slim bouguerra > Priority: Major > Attachments: HIVE-19194.patch > > > This tests fails randomly. If its not reproducible locally consider improving > its stability since it does fail once in a while on Hive QA. > {code} > java.lang.AssertionError: expected:<0> but was:<1> at > org.junit.Assert.fail(Assert.java:88) at > org.junit.Assert.failNotEquals(Assert.java:743) at > org.junit.Assert.assertEquals(Assert.java:118) at > org.junit.Assert.assertEquals(Assert.java:555) at > org.junit.Assert.assertEquals(Assert.java:542) at > org.apache.hadoop.hive.druid.TestDruidStorageHandler.testCommitMultiInsertOverwriteTable(TestDruidStorageHandler.java:414) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)