[ https://issues.apache.org/jira/browse/HIVE-19077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437893#comment-16437893 ]
Deepak Jaiswal commented on HIVE-19077: --------------------------------------- [~vihangk1] I never tried reattaching same version of patch but can look into it. The problem arises when a patch is large like mine (HIVE-18910). Practically, any commit would touch a file or more in it. Thus, by the time, the turn for my patch comes, it is no good as it wont apply due to merge conflicts. I have already lost several runs due to it. To avoid this, what I do is I refresh my patch every day in the evening to see if it applies, if it does not, I fix the conflicts and upload it. Once the queue finishes, hopefully over the weekend, I will try to see if a patch with same version enqueues. > Handle duplicate ptests requests standing in queue at the same time > ------------------------------------------------------------------- > > Key: HIVE-19077 > URL: https://issues.apache.org/jira/browse/HIVE-19077 > Project: Hive > Issue Type: Improvement > Components: Testing Infrastructure > Reporter: Adam Szita > Assignee: Adam Szita > Priority: Blocker > Fix For: 3.1.0 > > Attachments: HIVE-19077.0.patch, HIVE-19077.1.patch, > HIVE-19077.sslFix.patch > > > I've been keeping on eye on our {{PreCommit-HIVE-Build}} job, and what I > noticed that sometimes huge queues can build up, that contain jira's more > than once. (Yesterday I've seen a queue of 40, having 31 distinct jiras..) > Simple scenario is that I upload a patch, it gets queued for ptest (already > long queue), and 3 hours later I will update it, re-upload and re-queue. Now > the current ptest infra seems to be smart enough to always deal with the > latest patch, so what will happen is that the same patch will be tested 2 > times (with ~3 hours) diff, most probably with same result. > I propose we do some deduplication - if ptest starts running the request for > Jira X, then it can take a look on the current queue, and see if X is there > again. If so, it can skip for now, it will be picked up later anyway. > In practice this means that if you reconsider your patch and update it, your > original place in the queue will be gone (like as a penalty for changing it), > but overall it saves resources for the whole community. -- This message was sent by Atlassian JIRA (v7.6.3#76005)