[ https://issues.apache.org/jira/browse/HIVE-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436300#comment-16436300 ]
Hive QA commented on HIVE-19157: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 1s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} druid-handler: The patch generated 1 new + 138 unchanged - 1 fixed = 139 total (was 139) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 11m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-10163/dev-support/hive-personality.sh | | git revision | master / b7c64b1 | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-10163/yetus/diff-checkstyle-druid-handler.txt | | modules | C: druid-handler U: druid-handler | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-10163/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Assert that Insert into Druid Table fails if the publishing of metadata by > HS2 fails > ------------------------------------------------------------------------------------ > > Key: HIVE-19157 > URL: https://issues.apache.org/jira/browse/HIVE-19157 > Project: Hive > Issue Type: Bug > Reporter: slim bouguerra > Assignee: slim bouguerra > Priority: Major > Attachments: HIVE-19157.2.patch, HIVE-19157.patch > > > The usual work flow of loading Data into Druid relies on the fact that HS2 is > able to load Segments metadata from HDFS that are produced by LLAP/TEZ works. > In some cases where HS2 is not able to perform `ls` on the HDFS path the > insert into query will return success and will not insert any data. > This bug was introduced at function {code} > org.apache.hadoop.hive.druid.DruidStorageHandlerUtils#getCreatedSegments{code} > > when we added feature to allow create empty tables. > {code} > try { > fss = fs.listStatus(taskDir); > } catch (FileNotFoundException e) { > // This is a CREATE TABLE statement or query executed for CTAS/INSERT > // did not produce any result. We do not need to do anything, this is > // expected behavior. > return publishedSegmentsBuilder.build(); > } > {code} > Am still looking for the way to fix this, [~jcamachorodriguez]/[~ashutoshc] > any idea what is the best way to detect that it is an empty create table > statement? > -- This message was sent by Atlassian JIRA (v7.6.3#76005)