[
https://issues.apache.org/jira/browse/HIVE-19075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425056#comment-16425056
]
Hive QA commented on HIVE-19075:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12917328/HIVE-19075.2.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9986/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9986/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9986/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-04-04 06:02:43.302
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-9986/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-04-04 06:02:43.305
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 04f3be0 HIVE-17661 : DBTxnManager.acquireLocks() - MM tables
should use shared lock for Insert (Sergey Shelukhin, reviewed by Eugene Koifman)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 04f3be0 HIVE-17661 : DBTxnManager.acquireLocks() - MM tables
should use shared lock for Insert (Sergey Shelukhin, reviewed by Eugene Koifman)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-04-04 06:02:43.865
+ rm -rf ../yetus_PreCommit-HIVE-Build-9986
+ mkdir ../yetus_PreCommit-HIVE-Build-9986
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-9986
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9986/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
error: patch failed:
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:1037
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
cleanly.
error: patch failed:
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java:34
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java'
with conflicts.
Going to apply patch with: git apply -p0
error: patch failed:
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:1037
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java'
cleanly.
error: patch failed:
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java:34
Falling back to three-way merge...
Applied patch to
'standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java'
with conflicts.
U
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12917328 - PreCommit-HIVE-Build
> Fix NPE when trying to drop or get DB with null name
> ----------------------------------------------------
>
> Key: HIVE-19075
> URL: https://issues.apache.org/jira/browse/HIVE-19075
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Marta Kuczora
> Assignee: Marta Kuczora
> Priority: Minor
> Attachments: HIVE-19075.1.patch, HIVE-19075.2.patch
>
>
> The TestDatabases tests revealed that NPE is thrown if the get_database_core
> and drop_database_core methods are called with null DB name. These NPEs could
> be prevented with a simple null check and a MetaException with a proper error
> message should be thrown instead.
> Example: NPE is thrown in the following test cases
> * TestDatabases.testGetDatabaseNullName
> * TestDatabases.testDropDatabaseNullName
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
