[ https://issues.apache.org/jira/browse/HIVE-18905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421478#comment-16421478 ]
Hive QA commented on HIVE-18905: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 14s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} service: The patch generated 3 new + 36 unchanged - 0 fixed = 39 total (was 36) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 15s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 9m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9943/dev-support/hive-personality.sh | | git revision | master / 9d0f9c0 | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9943/yetus/diff-checkstyle-service.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9943/yetus/patch-asflicense-problems.txt | | modules | C: service U: service | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9943/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > HS2: SASL auth loads HiveConf for every JDBC call > ------------------------------------------------- > > Key: HIVE-18905 > URL: https://issues.apache.org/jira/browse/HIVE-18905 > Project: Hive > Issue Type: Bug > Reporter: Gopal V > Assignee: Igor Kryvenko > Priority: Minor > Attachments: HIVE-18905.01.patch, HIVE-18905.03.patch, > HIVE-18905.patch > > > SASL authentication filter does a new HiveConf() for no good reason. > {code} > public static PasswdAuthenticationProvider > getAuthenticationProvider(AuthMethods authMethod) > throws AuthenticationException { > return getAuthenticationProvider(authMethod, new HiveConf()); > } > {code} > The session HiveConf is not needed to do this operation & it can't be changed > after the HS2 starts up (today). > {code} > org.apache.hadoop.hive.conf.HiveConf.<init>() HiveConf.java:4404 > org.apache.hive.service.auth.AuthenticationProviderFactory.getAuthenticationProvider(AuthenticationProviderFactory$AuthMethods) > AuthenticationProviderFactory.java:61 > org.apache.hive.service.auth.PlainSaslHelper$PlainServerCallbackHandler.handle(Callback[]) > PlainSaslHelper.java:106 > org.apache.hive.service.auth.PlainSaslServer.evaluateResponse(byte[]) > PlainSaslServer.java:103 > org.apache.thrift.transport.TSaslTransport$SaslParticipant.evaluateChallengeOrResponse(byte[]) > TSaslTransport.java:539 > org.apache.thrift.transport.TSaslTransport.open() TSaslTransport.java:283 > org.apache.thrift.transport.TSaslServerTransport.open() > TSaslServerTransport.java:41 > org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TTransport) > TSaslServerTransport.java:216 > org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run() > TThreadPoolServer.java:269 > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor$Worker) > ThreadPoolExecutor.java:1142 > java.util.concurrent.ThreadPoolExecutor$Worker.run() > ThreadPoolExecutor.java:617 > java.lang.Thread.run() Thread.java:745 > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)