[ https://issues.apache.org/jira/browse/HIVE-19037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417524#comment-16417524 ]
Teddy Choi edited comment on HIVE-19037 at 3/28/18 3:37 PM: ------------------------------------------------------------ +1 LGTM, pending tests. I left few minor comments on RB. was (Author: teddy.choi): +1 LGTM. I left few minor comments on RB. > Vectorization: Miscellaneous cleanup > ------------------------------------ > > Key: HIVE-19037 > URL: https://issues.apache.org/jira/browse/HIVE-19037 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.0.0 > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Attachments: HIVE-19037.01.patch, HIVE-19037.02.patch > > > # Extraneous INFO logging in VectorReduceSinkCommonOperator > # NPE in EXPLAIN for some SelectColumnIsTrue vector expressions > # Don't throw instantiation exception when UDF has NULL SCALAR that cannot > match vectorization expression description. Catch it early and don't try to > create vectorization expression for UDF. (try VectorUDFAdaptor instead). > # Support vectorizing SELECT NULL. > # Support constant casting from \{STRING|CHAR|VARCHAR} to > \{LONG|DOUBLE|DECIMAL} case. > # Suppress fatal Vectorizer exceptions. Put single line exception stack > trace innotVectorizedReason. Add test only variable > hive.test.vectorizer.suppress.fatal.exceptions to turn that off so Vectorizer > execution failure can be found more easily. -- This message was sent by Atlassian JIRA (v7.6.3#76005)