[ https://issues.apache.org/jira/browse/HIVE-18560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394598#comment-16394598 ]
Zoltan Haindrich commented on HIVE-18560: ----------------------------------------- +1 > qtests: QTestUtil refactor/split - QOutProcessor > ------------------------------------------------ > > Key: HIVE-18560 > URL: https://issues.apache.org/jira/browse/HIVE-18560 > Project: Hive > Issue Type: Task > Components: Tests > Reporter: Laszlo Bodor > Assignee: Laszlo Bodor > Priority: Major > Attachments: HIVE-18560.01.patch, HIVE-18560.02.patch > > > QTestUtil needs some refactoring, as it has become a large, hard-to-maintain, > hard-to-test class with a bunch of responsibilities: > * running qtests > * parsing/evaluating results > * masking/processing results > First, I would extract a processing class from it (e.g. QOutProcessor or > something like that), which should be capable of being tested easily, and > contains all the logic what's needed to make the final q.out results from the > original q.out file. > This processing class shall remain untouched in case the testing > infrastructure (QTestUtil) is replaced or changed in some ways. -- This message was sent by Atlassian JIRA (v7.6.3#76005)