[ https://issues.apache.org/jira/browse/HIVE-18264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394099#comment-16394099 ]
Hive QA commented on HIVE-18264: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12913826/HIVE-18264.6.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9585/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9585/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9585/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-03-10 08:21:42.803 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-9585/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-03-10 08:21:42.806 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 41afa4e HIVE-18436: Upgrade to Spark 2.3.0 (Sahil Takiar, reviewed by Rui Li) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 41afa4e HIVE-18436: Upgrade to Spark 2.3.0 (Sahil Takiar, reviewed by Rui Li) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-03-10 08:21:46.190 + rm -rf ../yetus_PreCommit-HIVE-Build-9585 + mkdir ../yetus_PreCommit-HIVE-Build-9585 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-9585 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-9585/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java: does not exist in index error: a/service/src/java/org/apache/hive/service/server/HiveServer2.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/SharedCache.java: does not exist in index error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java: does not exist in index error: a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java: does not exist in index error: a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java: does not exist in index error: a/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/cache/TestCachedStore.java: does not exist in index error: a/standalone-metastore/src/test/resources/log4j2.properties: does not exist in index error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:71 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java' cleanly. error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:9964 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java' cleanly. error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java:707 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java' with conflicts. Going to apply patch with: git apply -p1 error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:71 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java' cleanly. error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:9964 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java' cleanly. error: patch failed: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java:707 Falling back to three-way merge... Applied patch to 'standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java' with conflicts. U standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12913826 - PreCommit-HIVE-Build > CachedStore: Store cached partitions/col stats within the table cache and > make prewarm non-blocking > --------------------------------------------------------------------------------------------------- > > Key: HIVE-18264 > URL: https://issues.apache.org/jira/browse/HIVE-18264 > Project: Hive > Issue Type: Sub-task > Reporter: Vaibhav Gumashta > Assignee: Vaibhav Gumashta > Priority: Major > Attachments: HIVE-18264.1.patch, HIVE-18264.2.patch, > HIVE-18264.3.patch, HIVE-18264.4.patch, HIVE-18264.5.patch, HIVE-18264.6.patch > > > Currently we have a separate cache for partitions and partition col stats > which results in some calls iterating through each of these for > retrieving/updating. For example, to modify a partition col stat, currently > we need to lock table, partition and partition col stats caches which are all > separate hashmaps. We can get better performance by organizing > hierarchically. For example, we can have a partition, partition col stats and > table col stats cache per table to improve on the previous mechanisms. This > will also result in better concurrency, since now instead of locking the > whole cache, we can selectively lock the table cache and modify multiple > tables in parallel. > In addition, currently, the prewarm mechanism populates all the caches > initially (it skips tables that do not pass whitelist/blacklist filter) and > it is a blocking call. This patch also makes prewarm non-blocking so that the > calls for tables that are already cached can be served from the memory and > the ones that are not can be served from the rdbms. -- This message was sent by Atlassian JIRA (v7.6.3#76005)