[
https://issues.apache.org/jira/browse/HIVE-18901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392977#comment-16392977
]
BELUGA BEHR commented on HIVE-18901:
------------------------------------
[~stakiar]
The following code is the primary method for adding resources to a job. It
should be the primary source of logging information and it already includes
logging which provides a list of resources that were successfully downloaded on
line 1474. It also logs any error that occurred during the process. This
information is more helpful that "I'm about to do something." The admin only
needs to know that it successfully did something or that it failed to do
something. The steps required to do that something, especially buried down in a
private method of a utility class from a different package, should be 'debug'
level logging.
https://github.com/apache/hive/blob/111ed096496c37674601173cfeaa40cbf948f878/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1423-L1477
We also have this somewhat duplicate logging as well:
{code}
converting to local hdfs:///user/hive/hiveauxjars/simplejava.jar
converting to local hdfs:///user/hive/hiveauxjars/sample_udf.jar
Added [/tmp/2a023cae-1e02-4cce-ade6-35d04f8f4f3d_resources/simplejava.jar,
/tmp/2a023cae-1e02-4cce-ade6-35d04f8f4f3d_resources/sample_udf.jar] to class
path
{code}
https://github.com/apache/hive/blob/111ed096496c37674601173cfeaa40cbf948f878/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1328
{code}
INFO : converting to local hdfs://nameservice1/user/hive/udf/exhibit.jar
INFO : Added [/tmp/6b16398c-854b-40a5-8439-b16d123e8f1e_resources/exhibit.jar]
to class path
INFO : Added resources: [hdfs://nameservice1/user/hive/udf/exhibit.jar]
{code}
The first line of "converting to local..." is just not that helpful/useful here.
Thanks!
> Lower ResourceDownloader Logging to Debug
> -----------------------------------------
>
> Key: HIVE-18901
> URL: https://issues.apache.org/jira/browse/HIVE-18901
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 3.0.0, 2.4.0
> Reporter: BELUGA BEHR
> Assignee: Kryvenko Igor
> Priority: Trivial
> Labels: noob
> Attachments: HIVE-18901.patch
>
>
> https://github.com/apache/hive/blob/6d890faf22fd1ede3658a5eed097476eab3c67e9/ql/src/java/org/apache/hadoop/hive/ql/util/ResourceDownloader.java#L98
> {code}
> LOG.info("converting to local {}", srcUri);
> {code}
> # Set to _debug_ level
> # Uppercase the "C" to "Converting" to match all other Hive logging
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
