[ https://issues.apache.org/jira/browse/HIVE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568064#comment-14568064 ]
Hive QA commented on HIVE-10748: -------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12736630/HIVE-10748.2.patch {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 8994 tests executed *Failed tests:* {noformat} TestUtil - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_fold_case org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_histogram_numeric org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx_cbo_2 {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4130/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4130/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4130/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12736630 - PreCommit-HIVE-TRUNK-Build > Replace StringBuffer with StringBuilder where possible > ------------------------------------------------------ > > Key: HIVE-10748 > URL: https://issues.apache.org/jira/browse/HIVE-10748 > Project: Hive > Issue Type: Improvement > Reporter: Alexander Pivovarov > Assignee: Alexander Pivovarov > Priority: Minor > Attachments: HIVE-10748.1.patch, HIVE-10748.1.patch, > HIVE-10748.2.patch > > > I found 40 places in Hive where "new StringBuffer(" is used. > "Where possible, it is recommended that StringBuilder be used in preference > to StringBuffer as it will be faster under most implementations" > https://docs.oracle.com/javase/7/docs/api/java/lang/StringBuilder.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)