[
https://issues.apache.org/jira/browse/HIVE-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313819#comment-16313819
]
Eugene Koifman edited comment on HIVE-18377 at 1/5/18 10:17 PM:
----------------------------------------------------------------
This won't work because doing this also enabled the default ZK based lock
manager which wedges a lot of these tests.
Many but not all run with with {{hive.support.concurrency=true}} and
{{hvie.txn.manager=rg.apache.hadoop.hive.ql.lockmgr.DbTxnManager}}
was (Author: ekoifman):
This won't work because doing this also enabled the default ZK based lock
manager which wedges a lot of these tests.
> avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
> ----------------------------------------------------------------
>
> Key: HIVE-18377
> URL: https://issues.apache.org/jira/browse/HIVE-18377
> Project: Hive
> Issue Type: Sub-task
> Components: Test, Transactions
> Reporter: Eugene Koifman
> Assignee: Eugene Koifman
> Attachments: HIVE-18377.02.patch
>
>
> many UTs (e.g. TestHCatMultiOutputFormat,
> BeelineWithHS2ConnectionFileTestBase, TestOperationLoggingAPIWithMr,
> HCatBaseTest and many others)
> explicitly set
> {{hiveConf.set(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname, "false");}}
> It would be better if they picked up the settings from
> data/conf/hive-site.xml.
> It adds consistency and makes it possible to run all tests with known config
> (at least approach this).
> The outline of the process is:
> 1. build copies {{\*-site.xml files from data/conf/\*\*/\*-site.xml}} to
> <module-name>target/testconf/
> 2. HiveConf picks up target/testconf/hive-site.xml
> 3. Various forms of *CliDriver may explicitly specify (e.g.
> MiniLlapLocalCliConfig) which hive-site.xml to use
>
> The first step is to see how many explicit settings of
> HIVE_SUPPORT_CONCURRENCY can be removed w/o breaking the tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
