[ https://issues.apache.org/jira/browse/HIVE-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564806#comment-14564806 ]
Xuefu Zhang commented on HIVE-10821: ------------------------------------ [~Ferd], thanks for working on this. If you're introducing the functionality of sourcing a script file in Beeline, I think we should follow Beeline's command style. That's is, all commands need to start with "!", for instance, !sql, !connect, and now !source. A command without "!" is treated as if it is started with "!sql". Thus, if you introduce a command like "source script.sql", it should be translated to "!sql source script.sql", which isn't intuitive. I'd suggest we instead introduce "!source script.sql" as the way to execute a script file in interactive mode. Then, for Hive CLI's beeline implementation, Hive CLI's "source script.sql" will be translated to "!source script.sql" via your translation method. Thoughts? > Beeline-CLI: Implement CLI source command using Beeline functionality > --------------------------------------------------------------------- > > Key: HIVE-10821 > URL: https://issues.apache.org/jira/browse/HIVE-10821 > Project: Hive > Issue Type: Sub-task > Components: CLI > Reporter: Ferdinand Xu > Assignee: Ferdinand Xu > Attachments: HIVE-10821.1-beeline-cli.patch, > HIVE-10821.1-beeline-cli.patch, HIVE-10821.2-beeline-cli.patch, > HIVE-10821.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)