[
https://issues.apache.org/jira/browse/HIVE-9605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14556396#comment-14556396
]
Sergio Peña commented on HIVE-9605:
-----------------------------------
[~Ferd] Could you please review this other patch that needs to be on master?.
> Remove parquet nested objects from wrapper writable objects
> -----------------------------------------------------------
>
> Key: HIVE-9605
> URL: https://issues.apache.org/jira/browse/HIVE-9605
> Project: Hive
> Issue Type: Sub-task
> Affects Versions: 0.14.0
> Reporter: Sergio Peña
> Assignee: Sergio Peña
> Fix For: parquet-branch
>
> Attachments: HIVE-9605.3.patch, HIVE-9605.4.patch, HIVE-9605.5.patch
>
>
> Parquet nested types are using an extra wrapper object (ArrayWritable) as a
> wrapper of map and list elements. This extra object is not needed and causing
> unnecessary memory allocations.
> An example of code is on HiveCollectionConverter.java:
> {noformat}
> public void end() {
> parent.set(index, wrapList(new ArrayWritable(
> Writable.class, list.toArray(new Writable[list.size()]))));
> }
> {noformat}
> This object is later unwrapped on AbstractParquetMapInspector, i.e.:
> {noformat}
> final Writable[] mapContainer = ((ArrayWritable) data).get();
> final Writable[] mapArray = ((ArrayWritable) mapContainer[0]).get();
> for (final Writable obj : mapArray) {
> ...
> }
> {noformat}
> We should get rid of this wrapper object to save time and memory.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
