[ https://issues.apache.org/jira/browse/HIVE-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553671#comment-14553671 ]
Hive QA commented on HIVE-10768: -------------------------------- {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12734246/HIVE-10768.3.patch {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 8967 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3971/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3971/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3971/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12734246 - PreCommit-HIVE-TRUNK-Build > In QTestGenTask.execute() we should not throw an exception right away if we > are unable to clean any old files > ------------------------------------------------------------------------------------------------------------- > > Key: HIVE-10768 > URL: https://issues.apache.org/jira/browse/HIVE-10768 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure > Reporter: Hari Sankar Sivarama Subramaniyan > Assignee: Hari Sankar Sivarama Subramaniyan > Attachments: HIVE-10768.1.patch, HIVE-10768.2.patch, > HIVE-10768.3.patch > > > Currently in QTestGenTask.execute(), we have code like : > {code} > if (logFile != null) { > File lf = new File(logFile); > if (lf.exists()) { > if (!lf.delete()) { > throw new Exception("Could not delete log file " + > lf.getCanonicalPath()); > } > {code} > If the log file gets locked due to some other process, it throws the above > exception and short circuits the entire test suite. We should provide a > mechanism to generate alternative new log files/temporary files whenever > possible to avoid unit test failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)