[ 
https://issues.apache.org/jira/browse/HIVE-10563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553054#comment-14553054
 ] 

Sushanth Sowmyan commented on HIVE-10563:
-----------------------------------------

Hi Hari,

Apologies for the late reply - having looked at all the .q files now, I'm +1 on 
it. However, I'm afraid I took too long to review this, and this now requires a 
rebase to update to latest. When applying this patch now, I get the following:

{noformat}
error: patch failed: 
ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out:694
error: 
ql/src/test/results/clientpositive/spark/vectorized_timestamp_funcs.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/tez/vectorized_timestamp_funcs.q.out:694
error: ql/src/test/results/clientpositive/tez/vectorized_timestamp_funcs.q.out: 
patch does not apply
error: patch failed: 
ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out:659
error: ql/src/test/results/clientpositive/vectorized_timestamp_funcs.q.out: 
patch does not apply
{noformat}

Could you please update the patch? Also, I noticed a couple of trailing spaces 
in a couple of your edits that git complains about. Once you have your patch up 
again, and we have the precommit tests run, I'll commit it quickly.

> MiniTezCliDriver tests ordering issues
> --------------------------------------
>
>                 Key: HIVE-10563
>                 URL: https://issues.apache.org/jira/browse/HIVE-10563
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-10563.1.patch, HIVE-10563.2.patch, 
> HIVE-10563.3.patch, HIVE-10563.4.patch, HIVE-10563.5.patch, HIVE-10563.6.patch
>
>
> There are a bunch of tests related to TestMiniTezCliDriver which gives 
> ordering issues when run on Centos/Windows/OSX



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to