[ https://issues.apache.org/jira/browse/HIVE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543086#comment-14543086 ]
Hive QA commented on HIVE-8583: ------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12732719/HIVE-8583.2.patch Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3884/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3884/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3884/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]] + export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera + export PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-maven-3.0.5/bin:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-3884/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 3138334 HIVE-10690: ArrayIndexOutOfBounds exception in MetaStoreDirectSql.aggrColStatsForPartitions() (Vaibhav Gumashta reviewed by Jason Dere) + git clean -f -d + git checkout master Already on 'master' + git reset --hard origin/master HEAD is now at 3138334 HIVE-10690: ArrayIndexOutOfBounds exception in MetaStoreDirectSql.aggrColStatsForPartitions() (Vaibhav Gumashta reviewed by Jason Dere) + git merge --ff-only origin/master Already up-to-date. + git gc + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12732719 - PreCommit-HIVE-TRUNK-Build > HIVE-8341 Cleanup & Test for hive.script.operator.env.blacklist > --------------------------------------------------------------- > > Key: HIVE-8583 > URL: https://issues.apache.org/jira/browse/HIVE-8583 > Project: Hive > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HIVE-8583.1.patch, HIVE-8583.2.patch > > > [~alangates] added the following in HIVE-8341: > {code} > String bl = > hconf.get(HiveConf.ConfVars.HIVESCRIPT_ENV_BLACKLIST.toString()); > if (bl != null && bl.length() > 0) { > String[] bls = bl.split(","); > for (String b : bls) { > b.replaceAll(".", "_"); > blackListedConfEntries.add(b); > } > } > {code} > The {{replaceAll}} call is confusing as its result is not used at all. > This patch contains the following: > * Minor style modification (missorted modifiers) > * Adds reading of default value for HIVESCRIPT_ENV_BLACKLIST > * Removes replaceAll > * Lets blackListed take a Configuration job as parameter which allowed me to > add a test for this -- This message was sent by Atlassian JIRA (v6.3.4#6332)