[
https://issues.apache.org/jira/browse/HIVE-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541397#comment-14541397
]
Ashutosh Chauhan commented on HIVE-10582:
-----------------------------------------
+1
> variable typo in HiveOpConverter (714) and SemanticAnalyzer (7496)
> ------------------------------------------------------------------
>
> Key: HIVE-10582
> URL: https://issues.apache.org/jira/browse/HIVE-10582
> Project: Hive
> Issue Type: Bug
> Components: Logical Optimizer
> Reporter: Alexander Pivovarov
> Assignee: Alexander Pivovarov
> Priority: Minor
> Attachments: HIVE-10582.1.patch, rb33790.patch
>
>
> HiveOpConverter lines 703-717
> {code}
> int kindex = exprBack == null ? -1 :
> ExprNodeDescUtils.indexOf(exprBack, reduceKeysBack);
> if (kindex >= 0) {
> ColumnInfo newColInfo = new ColumnInfo(colInfo);
> newColInfo.setInternalName(Utilities.ReduceField.KEY +
> ".reducesinkkey" + kindex);
> newColInfo.setAlias(outputColName);
> newColInfo.setTabAlias(colInfo.getTabAlias());
> outputColumns.add(newColInfo);
> index[i] = kindex;
> continue;
> }
> int vindex = exprBack == null ? -1 :
> ExprNodeDescUtils.indexOf(exprBack, reduceValuesBack);
> if (kindex >= 0) { // looks like it should be vindex instead of kindex
> index[i] = -vindex - 1;
> continue;
> }
> {code}
> Most probably the second "if (kindex >= 0)" (line 714) should be replaces
> with "if (vindex >= 0)"
> The same situation in SemanticAnalyzer (7483-7499)
> {code}
> int kindex = exprBack == null ? -1 :
> ExprNodeDescUtils.indexOf(exprBack, reduceKeysBack);
> if (kindex >= 0) {
> ColumnInfo newColInfo = new ColumnInfo(colInfo);
> newColInfo.setInternalName(Utilities.ReduceField.KEY +
> ".reducesinkkey" + kindex);
> newColInfo.setTabAlias(nm[0]);
> outputRR.put(nm[0], nm[1], newColInfo);
> if (nm2 != null) {
> outputRR.addMappingOnly(nm2[0], nm2[1], newColInfo);
> }
> index[i] = kindex;
> continue;
> }
> int vindex = exprBack == null ? -1 :
> ExprNodeDescUtils.indexOf(exprBack, reduceValuesBack);
> if (kindex >= 0) { // looks like it should be vindex instead of kindex
> index[i] = -vindex - 1;
> continue;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
