[ https://issues.apache.org/jira/browse/HIVE-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527167#comment-14527167 ]
Reuben Kuhnert commented on HIVE-10190: --------------------------------------- I just tried running some tests locally: {code} sircodesalot@excalibur-elementary:~/Dev/Cloudera/hive/itests$ mvn test -Phadoop-2 -Dtest=TestCliDriver -Dqfile=input32.q,auto_join_nulls.q,ppd_join3.q {code} {code} [INFO] Hive Integration - Parent ......................... SUCCESS [ 3.060 s] [INFO] Hive Integration - Custom Serde ................... SUCCESS [ 5.458 s] [INFO] Hive Integration - HCatalog Unit Tests ............ SUCCESS [ 4.795 s] [INFO] Hive Integration - Testing Utilities .............. SUCCESS [ 5.818 s] [INFO] Hive Integration - Unit Tests ..................... SUCCESS [ 8.128 s] [INFO] Hive Integration - Test Serde ..................... SUCCESS [ 1.488 s] [INFO] Hive Integration - QFile Tests .................... SUCCESS [02:48 min] [INFO] JMH benchmark: Hive ............................... SUCCESS [ 1.425 s] [INFO] Hive Integration - QFile Spark Tests .............. SUCCESS [ 5.783 s] [INFO] Hive Integration - Unit Tests - Hadoop 2 .......... SUCCESS [ 2.002 s] [INFO] Hive Integration - Unit Tests with miniKdc ........ SUCCESS [ 3.740 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 03:31 min [INFO] Finished at: 2015-05-04T14:57:52-06:00 [INFO] Final Memory: 78M/186M [INFO] ------------------------------------------------------------------------ {code} and they all seem to pass. I'll try running all tests, and see what happens. Also re-uploading to jenkins to see if maybe the issue was my previous bad build. > CBO: AST mode checks for TABLESAMPLE with > AST.toString().contains("TOK_TABLESPLITSAMPLE") > ----------------------------------------------------------------------------------------- > > Key: HIVE-10190 > URL: https://issues.apache.org/jira/browse/HIVE-10190 > Project: Hive > Issue Type: Bug > Components: CBO > Affects Versions: 1.2.0 > Reporter: Gopal V > Assignee: Reuben Kuhnert > Priority: Trivial > Labels: perfomance > Attachments: HIVE-10190-querygen.py, HIVE-10190.01.patch, > HIVE-10190.02.patch, HIVE-10190.03.patch, HIVE-10190.04.patch, > HIVE-10190.05.patch, HIVE-10190.05.patch, HIVE-10190.06.patch, > HIVE-10190.07.patch > > > {code} > public static boolean validateASTForUnsupportedTokens(ASTNode ast) { > String astTree = ast.toStringTree(); > // if any of following tokens are present in AST, bail out > String[] tokens = { "TOK_CHARSETLITERAL", "TOK_TABLESPLITSAMPLE" }; > for (String token : tokens) { > if (astTree.contains(token)) { > return false; > } > } > return true; > } > {code} > This is an issue for a SQL query which is bigger in AST form than in text > (~700kb). -- This message was sent by Atlassian JIRA (v6.3.4#6332)