[ https://issues.apache.org/jira/browse/HIVE-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488228#comment-14488228 ]
Swarnim Kulkarni commented on HIVE-3378: ---------------------------------------- [~apivovarov] Left a few comments on the review. In my opinion, the implementation feels a little complicated. First of all, may be I am missing something, but why do we need to extend a GenericUDF and not a simple UDF? Can't we have an implementation similar to the dayofmonth[1]? [1] https://github.com/cloudera/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java > UDF to obtain the numeric day of an year from date or timestamp in > HIVE. > ---------------------------------------------------------------------------- > > Key: HIVE-3378 > URL: https://issues.apache.org/jira/browse/HIVE-3378 > Project: Hive > Issue Type: New Feature > Components: UDF > Affects Versions: 0.8.1, 0.9.0 > Reporter: Deepti Antony > Assignee: Alexander Pivovarov > Attachments: HIVE-3378.02.patch, HIVE-3378.02.patch, > HIVE-3378.1.patch.txt > > > Hive current releases lacks a function which returns the numeric day of an > year if a date or timestamp is given .The function DAYOFYEAR(date) would > return the numeric day from a date / timestamp or which would be useful > while using HiveQL.DAYOFYEAR can be used to compare data with respect to > number of days till the given date.It can be used in different domains. -- This message was sent by Atlassian JIRA (v6.3.4#6332)