[ 
https://issues.apache.org/jira/browse/HIVE-10159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395244#comment-14395244
 ] 

Alexander Pivovarov commented on HIVE-10159:
--------------------------------------------

The change causes TestSparkCliDriver fails on mapjoin_decimal.q test with the 
following stacktrace.
{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hive.cli.TestSparkCliDriver
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 98.25 sec <<< 
FAILURE! - in org.apache.hadoop.hive.cli.TestSparkCliDriver
testCliDriver_mapjoin_decimal(org.apache.hadoop.hive.cli.TestSparkCliDriver)  
Time elapsed: 7.236 sec  <<< FAILURE!
junit.framework.AssertionFailedError: Unexpected exception 
junit.framework.AssertionFailedError: Client Execution failed with error code = 
3 running 

select t1.dec, t2.dec from t1 join t2 on (t1.dec=t2.dec)
See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or 
check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ 
for specific test cases logs.
        at junit.framework.Assert.fail(Assert.java:57)
        at org.apache.hadoop.hive.ql.QTestUtil.failed(QTestUtil.java:1967)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.runTest(TestSparkCliDriver.java:141)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_mapjoin_decimal(TestSparkCliDriver.java:123)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at junit.framework.TestCase.runTest(TestCase.java:176)
        at junit.framework.TestCase.runBare(TestCase.java:141)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at junit.framework.TestCase.run(TestCase.java:129)
        at junit.framework.TestSuite.runTest(TestSuite.java:255)
        at junit.framework.TestSuite.run(TestSuite.java:250)
        at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
        at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
        at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
        at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

 running 

select t1.dec, t2.dec from t1 join t2 on (t1.dec=t2.dec)
See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or 
check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ 
for specific test cases logs.
        at junit.framework.Assert.fail(Assert.java:57)
        at org.apache.hadoop.hive.ql.QTestUtil.failed(QTestUtil.java:1988)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.runTest(TestSparkCliDriver.java:149)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_mapjoin_decimal(TestSparkCliDriver.java:123)


Results :

Failed tests: 
  TestSparkCliDriver.testCliDriver_mapjoin_decimal:123->runTest:149 Unexpected 
exception junit.framework.AssertionFailedError: Client Execution failed with 
error code = 3 running 

select t1.dec, t2.dec from t1 join t2 on (t1.dec=t2.dec)
See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or 
check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ 
for specific test cases logs.
        at junit.framework.Assert.fail(Assert.java:57)
        at org.apache.hadoop.hive.ql.QTestUtil.failed(QTestUtil.java:1967)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.runTest(TestSparkCliDriver.java:141)
        at 
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_mapjoin_decimal(TestSparkCliDriver.java:123)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at junit.framework.TestCase.runTest(TestCase.java:176)
        at junit.framework.TestCase.runBare(TestCase.java:141)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at junit.framework.TestCase.run(TestCase.java:129)
        at junit.framework.TestSuite.runTest(TestSuite.java:255)
        at junit.framework.TestSuite.run(TestSuite.java:250)
        at 
org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:264)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
        at 
org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
        at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
        at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
        at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

 running 

select t1.dec, t2.dec from t1 join t2 on (t1.dec=t2.dec)
See ./ql/target/tmp/log/hive.log or ./itests/qtest/target/tmp/log/hive.log, or 
check ./ql/target/surefire-reports or ./itests/qtest/target/surefire-reports/ 
for specific test cases logs.

Tests run: 2, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:04 min
[INFO] Finished at: 2015-04-03T15:29:22-07:00
[INFO] Final Memory: 75M/750M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.16:test (default-test) on 
project hive-it-qfile-spark: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/workhive/hive/itests/qtest-spark/target/surefire-reports for the individual 
test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
{code}


> HashTableSinkDesc and MapJoinDesc keyTblDesc can be replaced by 
> JoinDesc.keyTableDesc
> -------------------------------------------------------------------------------------
>
>                 Key: HIVE-10159
>                 URL: https://issues.apache.org/jira/browse/HIVE-10159
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Planning
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>         Attachments: HIVE-10159.1.patch, HIVE-10159.1.patch, 
> HIVE-10159.1.patch
>
>
> MapJoinDesc and HashTableSinkDesc are derived from JoinDesc
> HashTableSinkDesc and MapJoinDesc have keyTblDesc field.
> JoinDesc has keyTableDesc field.
> I think HashTableSinkDesc and MapJoinDesc can use superclass (JoinDesc) 
> keyTableDesc field instead of defining their own keyTblDesc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to