[ 
https://issues.apache.org/jira/browse/HIVE-10128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393609#comment-14393609
 ] 

Lefty Leverenz commented on HIVE-10128:
---------------------------------------

bq.  Here's my +1 from yesterday. Since it's already tomorrow, you should be 
able to check this in today.

Hm, sounds logical.  But (putting on my quibbling cap) isn't the one-day delay 
supposed to give _other_ people a chance to weigh in?

> BytesBytesMultiHashMap does not allow concurrent read-only access
> -----------------------------------------------------------------
>
>                 Key: HIVE-10128
>                 URL: https://issues.apache.org/jira/browse/HIVE-10128
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gopal V
>            Assignee: Sergey Shelukhin
>             Fix For: llap
>
>         Attachments: HIVE-10128.01.patch, HIVE-10128.02.patch, 
> HIVE-10128.03.patch, HIVE-10128.patch, hashmap-after.png, 
> hashmap-sync-source.png, hashmap-sync.png
>
>
> The multi-threaded performance takes a serious hit when LLAP shares 
> hashtables between the probe threads running in parallel. 
> !hashmap-sync.png!
> This is an explicit synchronized block inside ReusableRowContainer which 
> triggers this particular pattern.
> !hashmap-sync-source.png!
> Looking deeper into the code, the synchronization seems to be caused due to 
> the fact that WriteBuffers.setReadPoint modifies the otherwise read-only 
> hashtable.
> To generate this sort of result, run LLAP at a WARN log-level, to avoid all 
> the log synchronization that otherwise affects the thread sync.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to