taklwu commented on code in PR #8704:
URL: https://github.com/apache/hbase/pull/8704#discussion_r4136407678
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java:
##########
@@ -641,11 +641,21 @@ public void onConfigurationChange(Configuration conf) {
@Override
public void registerChildren(ConfigurationManager manager) {
- manager.registerObserver(blockCache);
+ if (blockCache != null) {
+ manager.registerObserver(blockCache);
+ }
+ if(cacheAccessService != null) {
+ manager.registerObserver(cacheAccessService);
Review Comment:
can you double check this comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
