wchevreuil commented on code in PR #8700:
URL: https://github.com/apache/hbase/pull/8700#discussion_r4102812537
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java:
##########
@@ -768,6 +768,16 @@ private void preTransitCheck(RegionStateNode regionNode,
RegionState.State[] exp
if (!regionNode.isInState(expectedStates)) {
throw new DoNotRetryRegionException(UNEXPECTED_STATE_REGION +
regionNode);
}
+ // if we don't write the state as SPLIT to the meta, we would need this
check.
Review Comment:
Ok, after reviewing the state machine diagram on the [official
doc](https://hbase.apache.org/docs/architecture/regions#region-state-transition),
it seems the SPLIT state should be a terminal state where a split region ends,
so having a split region in CLOSED state seems inconsistent with the diagram.
Therefore, setting the SPLIT state would be more compliant with the
documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
