taklwu commented on code in PR #8697:
URL: https://github.com/apache/hbase/pull/8697#discussion_r4097064604
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/cache/TieredInclusiveTopology.java:
##########
@@ -133,4 +133,20 @@ public void shutdown() {
public boolean handleEviction(BlockCacheKey cacheKey, Cacheable block,
CacheEngine sourceEngine) {
return false;
}
+
+ /**
+ * Handles an access to a block found in this inclusive topology.
+ * <p>
+ * A block found in L1 is also expected to be present in L2. Notify L2 about
the access so that it
+ * can update any access-based metadata without reading the block. An L2 hit
requires no
+ * additional notification because L2 observed the access directly.
+ * @param cacheKey key identifying the accessed block
+ * @param sourceEngine engine in which the block was found
+ */
+ @Override
+ public void handleAccess(BlockCacheKey cacheKey, CacheEngine sourceEngine) {
+ if (sourceEngine == l1) {
+ l2.touch(cacheKey);
Review Comment:
nit: this is the same problem I found, now it's no ops and we don't have any
example yet doing anything for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
