Sigma-Ma commented on code in PR #8566:
URL: https://github.com/apache/hbase/pull/8566#discussion_r3964155857


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:
##########
@@ -1257,18 +1263,155 @@ private void parallelSeek(final List<? extends 
KeyValueScanner> scanners, final
         latch.countDown();
       }
     }
+    InterruptedIOException interruptedException = null;
+    while(true) {
+      try {
+        latch.await();
+        break;
+      } catch (InterruptedException ie) {
+        interruptedException = (InterruptedIOException) new 
InterruptedIOException().initCause(ie);
+      }
+    }
+    if (interruptedException != null) {

Review Comment:
   Since parallelSeek now waits for handlers after interruption, could we 
restore the interrupt status before throwing, as the adaptive path does? 
CountDownLatch.await() clears it.
   
   Alternatively, we could leave the existing parallelSeek behavior unchanged 
here and handle it in a separate JIRA.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to