Umeshkumar9414 commented on PR #8547: URL: https://github.com/apache/hbase/pull/8547#issuecomment-5317634414
Pushed 3dcff721ab addressing the remaining review feedback: **@apurtell's suggestion** — switched `getRSGroupInfo()` to read `hbase:rsgroup` directly via `RSGroupTableAccessor` (from `hbase-client`) instead of the `RSGroupAdminEndpoint` coprocessor RPC. This let me move `RSGroupAdmin.proto` back to `hbase-rsgroup`, so `hbase-protocol` no longer carries it — the messy proto relocation is gone. **Copilot findings:** - `getRSGroupInfo()` now throws `IOException` instead of returning `null` when RSGroups are enabled but the server can't be matched to any group. Previously that case fell through to treating every online server as a valid destination, which defeats RSGroup isolation during decommission. - `testUnloadRegionsRespectsRSGroup` now picks the decommission target by checking which `rsservers` member actually hosts a `TABLE_NAME` region, rather than assuming `rsservers.get(0)`. `moveTableRegionsToGroup()` places regions via `randomAssignment()`, so the old assumption could let the test pass without exercising the move/filter path at all. - Fixed the Javadoc on `testUnloadDefaultGroupServerWithRSGroupEnabled` — it said regions "spread across all available servers (not filtered)" but the test actually asserts destinations are filtered to the default group. Verified: `TestRegionMoverFilterRSGroupServers` (3/3) and `TestRegionMoverWithRSGroupEnable` (2/2) pass, checkstyle and spotbugs clean on both `hbase-server` and `hbase-rsgroup`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
