mnpoonia commented on code in PR #8389:
URL: https://github.com/apache/hbase/pull/8389#discussion_r3781475516
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperStub.java:
##########
@@ -87,6 +87,16 @@ public long getStoreFileSize() {
return 1900;
}
+ @Override
Review Comment:
This verifies source export from a fixed wrapper stub, but it does not
exercise `MetricsRegionServerWrapperImpl` aggregation or ratio calculation.
Could we extend `TestMetricsRegionServerAggregate` to assert the summed
compressed and uncompressed sizes, along with the resulting `uncompressed /
compressed` ratio, including the empty-aggregate case?
Using stores with different individual ratios would also verify that this
remains a weighted aggregate rather than an average of per-store ratios.
Basically +1 to Andrew's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
