mwkang commented on code in PR #8469:
URL: https://github.com/apache/hbase/pull/8469#discussion_r3655204151
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -1798,70 +1829,110 @@ private void checkIOErrorIsTolerated() {
if (isCacheEnabled() && (now - ioErrorStartTimeTmp) >
this.ioErrorsTolerationDuration) {
LOG.error("IO errors duration time has exceeded " +
ioErrorsTolerationDuration
+ "ms, disabling cache, please check your IOEngine");
- disableCache();
+ disableCache(false);
Review Comment:
Explicit shutdown and the IO-error threshold path now use the same disable
and cleanup flow. When the cache is persistent, cleanup always performs the
final backing-map persistence regardless of what triggered the disable.
The retriever, writer threads, and persister are stopped before the final
persistence pass. If persistence fails, the remaining owner references are
still released while the previous committed checkpoint is left intact.
The empty final checkpoint and final-persistence failure cases are covered
by dedicated regression tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
