Umeshkumar9414 commented on code in PR #7864:
URL: https://github.com/apache/hbase/pull/7864#discussion_r2893593948
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/AdaptiveLifoCoDelCallQueue.java:
##########
@@ -44,7 +44,7 @@ public class AdaptiveLifoCoDelCallQueue implements
BlockingQueue<CallRunner> {
private LinkedBlockingDeque<CallRunner> queue;
// so we can calculate actual threshold to switch to LIFO under load
- private int maxCapacity;
+ private int currentQueueLimit;
Review Comment:
I made currentQueueLimit volatile.
> Please don't shadow. Why do we need this separately?
Generally a queue should only handle hard limit and layer above it can
handle soft limit and that is what was happening but for codel, we needed queue
to know the soft limit as well, I didn't saw a way to use the same variable at
both place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
