anmolnar commented on code in PR #7857:
URL: https://github.com/apache/hbase/pull/7857#discussion_r2892743882
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java:
##########
@@ -405,14 +405,14 @@ private void negotiateActiveClusterSuffixFile(long wait)
throws IOException {
this.activeClusterSuffix = acs;
} else {
// throw error
- LOG.info("rootdir {} : Active Cluster File Suffix {} ", rootdir,
acs);
+ LOG.info("rootdir {} : Read replica active cluster file suffix {} ",
rootdir, acs);
throw new IOException("Cannot start master, because another cluster
is running in active "
- + "(read-write) mode on this storage location. Active Cluster Id:
{} " + acs
- + " This cluster Id: " + getClusterId());
+ + "(read-write) mode on this storage location. Active Cluster Id:
" + acs
+ + ", This cluster Id: " + getClusterId());
Review Comment:
`getClusterId()` alone is not enough. We need to log the cluster id + suffix
like this:
```
dcf9e176-8437-49a9-9e91-b221b94e8fe3:<blank>
```
or
```
dcf9e176-8437-49a9-9e91-b221b94e8fe3:replica1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
