charlesconnell commented on code in PR #7288:
URL: https://github.com/apache/hbase/pull/7288#discussion_r2334369801
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java:
##########
@@ -2651,4 +2651,7 @@ List<LogEntry> getLogEntries(Set<ServerName> serverNames,
String logType, Server
* Get the list of cached files
*/
List<String> getCachedFilesList(ServerName serverName) throws IOException;
+
+ @InterfaceAudience.Private
+ void restoreBackupSystemTable(String snapshotName) throws IOException;
Review Comment:
If this doesn't need to be public, it shouldn't go on the very public Admin
interface. You could use `Admin#execProcedure()` instead because you're
basically just starting a procedure. You could also add an PRC to
`MasterService` that you could call from `BackupSystemTable`. These would both
accomplish communicating to the HMaster, but more privately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
